Use quotes around attribute selectors for jQuery Tabs #626
Conversation
…the scrollable rename addItem to appendItem for consistency with new method
ghost
assigned 
|
|
||
| self.seekTo(self.getIndex() +1, 0); | ||
|
|
||
| fire.trigger("onAddItemBefore", [item]); |
There was a problem hiding this comment.
Please change the event name to "onBeforeAddItem" so that it matches the way the other events are named.
There was a problem hiding this comment.
Shouldn't it then be OnBeforeAddItemBefore? (Event triggered before we add an item before the other scrollable items)
There was a problem hiding this comment.
You know what, I must have a brain freeze or something. Totally mistook this for what it actually does. Ignore my comment regarding the name change. Though I will note that because this is a new feature, it probably won't be in the next release since I'm hoping for that release to be a bug fix release only.
|
Please follow guidelines here: Also, we'll have the fix for the tabs with #679. |
|
So what happened to adding this feature in? |
As per #596